Cleanup MetadataLoader tests #6484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Oops, though this was an issue 😅. Thanks @alamb, that was fast. 🚀 |
Contributor
Author
LOL -- I had made the change locally and figured there was no reason to push to your PR or hold the PR anymore so I just merged it in and made this one thank you for being so attentive |
etseidl
approved these changes
Sep 30, 2024
Contributor
etseidl
left a comment
etseidl
left a comment
There was a problem hiding this comment.
Looks good and reverted. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #6474
Rationale for this change
There were some test changes in #6474 that made them more complicated and were no longer necessary
What changes are included in this PR?
Revert the changes to tests from #6474
Are there any user-facing changes?
This is all internal