Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support every data type in in sort #6911

Open
3 tasks
rluvaton opened this issue Dec 26, 2024 · 2 comments
Open
3 tasks

Support every data type in in sort #6911

rluvaton opened this issue Dec 26, 2024 · 2 comments
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@rluvaton
Copy link
Contributor

rluvaton commented Dec 26, 2024

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
I want to be able to sort every valid array

Describe the solution you'd like
calling arrow-ord::sort::sort on any type should just work

Describe alternatives you've considered
Not using the sort kernel


This requires couple of changes

@rluvaton rluvaton added the enhancement Any new improvement worthy of a entry in the changelog label Dec 26, 2024
@rluvaton
Copy link
Contributor Author

rluvaton commented Dec 26, 2024

I'm currently working on sorting list of booleans - there is a PR ready

working now on the sorting nested lists of any depth

@tustvold
Copy link
Contributor

tustvold commented Dec 26, 2024

For nested data types we should direct people to using https://docs.rs/arrow-row/latest/arrow_row/#lexsort.

We shouldn't add support to the sort kernel, as it will just be slower. It also has challenges when it comes to null ordering

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

No branches or pull requests

2 participants