Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parquet / Build wasm32 (pull_request) CI check failing on main #5565

Closed
alamb opened this issue Mar 28, 2024 · 6 comments · Fixed by #5567
Closed

parquet / Build wasm32 (pull_request) CI check failing on main #5565

alamb opened this issue Mar 28, 2024 · 6 comments · Fixed by #5567
Labels
arrow Changes to the arrow crate bug parquet Changes to the parquet crate

Comments

@alamb
Copy link
Contributor

alamb commented Mar 28, 2024

Describe the bug
parquet / Build wasm32 (pull_request) CI check is failing on main , evenwi

To Reproduce
Make a PR with no code changes, for example #5564

It fails like https://github.com/apache/arrow-rs/actions/runs/8474125669/job/23219908414?pr=5564

Run cargo build -p parquet --target wasm32-unknown-unknown
  cargo build -p parquet --target wasm3[2](https://github.com/apache/arrow-rs/actions/runs/8474125669/job/23219908414?pr=5564#step:6:2)-unknown-unknown
  shell: sh -e {0}
  env:
    RUSTFLAGS: -C debuginfo=1
    RUST_BACKTRACE: 1
   Compiling autocfg v1.2.0
   Compiling libm v0.2.8
   Compiling libc v0.2.15[3](https://github.com/apache/arrow-rs/actions/runs/8474125669/job/23219908414?pr=5564#step:6:3)
...
Compiling arrow-cast v51.0.0 (/__w/arrow-rs/arrow-rs/arrow-cast)
The following warnings were emitted during compilation:

warning: zstd-sys@2.0.10+zstd.1.5.6: In file included from zstd/lib/common/zstd_common.c:18:
warning: zstd-sys@2.0.10+zstd.1.5.6: In file included from zstd/lib/common/zstd_internal.h:35:
warning: zstd-sys@2.0.10+zstd.1.5.6: zstd/lib/common/xxhash.h:3157:22: error: called object type 'int' is not a function or function pointer
warning: zstd-sys@2.0.10+zstd.1.5.6:     XXH_STATIC_ASSERT(sizeof(XXH32_canonical_t) == sizeof(XXH32_hash_t));
warning: zstd-sys@2.0.10+zstd.1.5.6:     ~~~~~~~~~~~~~~~~~^
warning: zstd-sys@2.0.10+zstd.1.5.6: zstd/lib/common/xxhash.h:3600:22: error: called object type 'int' is not a function or function pointer
warning: zstd-sys@2.0.10+zstd.1.5.6:     XXH_STATIC_ASSERT(sizeof(XXH[64](https://github.com/apache/arrow-rs/actions/runs/8474125669/job/23219908414?pr=5564#step:6:65)_canonical_t) == sizeof(XXH64_hash_t));
warning: zstd-sys@2.0.10+zstd.1.5.6:     ~~~~~~~~~~~~~~~~~^
warning: zstd-sys@2.0.10+zstd.1.5.6: 2 errors generated.
...

Expected behavior
CI checks should pass when no code is chanegd

Additional context
Reported by @XiangpengHao on #5564

@Jefffrey
Copy link
Contributor

Jefffrey commented Mar 29, 2024

(Just some random notes as I investigate a bit)

Success: https://github.com/apache/arrow-rs/actions/runs/8441272186/job/23120055830

  • Runner Image Version: 20240317.1.0
  • Compiling zstd-sys v2.0.9+zstd.1.5.5

Failure: https://github.com/apache/arrow-rs/actions/runs/8466052041/job/23193980665

  • Runner Image Version: 20240324.2.0
  • Compiling zstd-sys v2.0.10+zstd.1.5.6

Also of note: gyscos/zstd-rs#269

Edit: seems like it is due to bump from zstd-sys v2.0.9+zstd.1.5.5 -> zstd-sys v2.0.10+zstd.1.5.6

See #5567

@kylebarron
Copy link
Contributor

The shim defining XXH_STATIC_ASSERT is pretty old. So my guess is that zstd.1.5.5 -> zstd.1.5.6 used XXH_STATIC_ASSERT in a new way that's incompatible with the shim?

@alamb
Copy link
Contributor Author

alamb commented Mar 29, 2024

Thank you @kylebarron and @Jefffrey for debugging and fixing this issue

@tustvold
Copy link
Contributor

label_issue.py automatically added labels {'arrow'} from #5525

@tustvold
Copy link
Contributor

label_issue.py automatically added labels {'parquet'} from #5567

@tustvold tustvold added the parquet Changes to the parquet crate label Apr 17, 2024
@alamb
Copy link
Contributor Author

alamb commented Jun 1, 2024

This may be another symptom of apache/arrow#41637 (aka a really old glibc version in the integration tests)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate bug parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants