Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cast kernel doesn't return null for string to integral cases when overflowing under safe option enabled #5397

Closed
viirya opened this issue Feb 13, 2024 · 1 comment · Fixed by #5398
Closed

Cast kernel doesn't return null for string to integral cases when overflowing under safe option enabled #5397

viirya opened this issue Feb 13, 2024 · 1 comment · Fixed by #5398
Labels
arrow Changes to the arrow crate bug

Comments

@viirya
Copy link
Member

viirya commented Feb 13, 2024

Describe the bug

We found that cast kernel doesn't return null for string to integral cases when overflowing: apache/datafusion-comet#15

lexical_core parser doesn't actually do the overflow check.

To Reproduce

Expected behavior

Additional context
@viirya viirya added the bug label Feb 13, 2024
@viirya viirya mentioned this issue Feb 13, 2024
Merged
@tustvold tustvold added the arrow Changes to the arrow crate label Mar 1, 2024
@tustvold
Copy link
Contributor

tustvold commented Mar 1, 2024

label_issue.py automatically added labels {'arrow'} from #5398

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Return null for overflow when casting string to integer under safe option enabled viirya/arrow-rs
2 participants
@viirya @tustvold