Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

object_store: Builders (S3/Azure/GCS) are missing the get method to get the actual configuration information #4021

Closed
r4ntix opened this issue Apr 5, 2023 · 1 comment · Fixed by #4035
Closed

object_store: Builders (S3/Azure/GCS) are missing the get method to get the actual configuration information #4021

r4ntix opened this issue Apr 5, 2023 · 1 comment · Fixed by #4035
Labels
enhancement Any new improvement worthy of a entry in the changelog object-store Object Store Interface

Comments

@r4ntix
Copy link
Contributor

r4ntix commented Apr 5, 2023

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

The current Builders (S3/Azure/GCS) only provide the set method, e.g. builder.with_access_key_id().

Since the current Builders also support getting configuration information from the ::from_env(), so we also need the get method to verify that the actual configuration is as expected.

Describe the solution you'd like

  • support get method

Describe alternatives you've considered

  • make struct fields of builders to pub

Additional context
@r4ntix r4ntix added the enhancement Any new improvement worthy of a entry in the changelog label Apr 5, 2023
@alamb alamb added the object-store Object Store Interface label Apr 5, 2023
@alamb
Copy link
Contributor

alamb commented Apr 5, 2023

Related PR: apache/datafusion#5732

@r4ntix r4ntix mentioned this issue Apr 7, 2023
Merged
This was referenced Jun 7, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Any new improvement worthy of a entry in the changelog object-store Object Store Interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add get_config_value to AWS/Azure/GCP Builders r4ntix/arrow-rs
2 participants
@r4ntix @alamb