Skip to content

Commit 46fa925

Browse files
committed
Remove old TODO
1 parent 01224e1 commit 46fa925

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

arrow-string/src/like.rs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -246,8 +246,6 @@ macro_rules! datum_function {
246246
let left_type = left_array.data_type();
247247
let right_type = right_array.data_type();
248248

249-
// TODO(alexandreyc): check if PartialEq for DataType is deep or shallow
250-
// i.e. does it check nested subtypes for equality?
251249
if left_type != right_type {
252250
return Err(ArrowError::ComputeError(
253251
"Arrays must have the same data type".to_string(),
@@ -916,7 +914,7 @@ mod tests {
916914
vec![true, true, true, false, false, true, false, false]
917915
);
918916

919-
// TODO
917+
// OK
920918
test_dict_utf8!(
921919
test_utf8_array_like_dict,
922920
vec!["arrow", "arrow", "arrow", "arrow", "arrow", "arrows", "arrow", "arrow"],

0 commit comments

Comments
 (0)