Skip to content

GH-155: Delegate opening mTLS cert files to build() #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

GH-155: Delegate opening mTLS cert files to build() #783

wants to merge 2 commits into from

Conversation

rtadepalli
Copy link
Contributor

What's Changed

Make FlightServer.Builder store File and delegate opening the file to the actual build() method.

Closes #155.

@rtadepalli
Copy link
Contributor Author

Could I please get a review @lidavidm thanks.

@lidavidm
Copy link
Member

Sorry - I have basically 0 time for arrow-java recently. I will try to get to all the reviews soon but I can't make any promises.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidavidm lidavidm Awaiting requested review from lidavidm lidavidm is a code owner

@laurentgo laurentgo Awaiting requested review from laurentgo laurentgo is a code owner

@wgtmac wgtmac Awaiting requested review from wgtmac wgtmac is a code owner

@jbonofre jbonofre Awaiting requested review from jbonofre jbonofre is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Java][FlightRPC] FlightServer builder should store File, not InputStream
2 participants
@rtadepalli @lidavidm