Conversation
This comment has been minimized.
This comment has been minimized.
|
That's not correct. It should be SNAPSHOT version as the release is done by the maven-release-plugin. |
kou
left a comment
There was a problem hiding this comment.
+1
This is correct.
We don't create a release branch. We release a RC from main. So we should use no -SNAPSHOT version here.
|
FYI: We don't use maven-release-plugin for our release. |
Ah, sorry. We use maven-release-plugin. https://github.com/apache/arrow-java/blob/main/dev/release/bump_version.sh that creates this PR uses maven-release-plugin. |
|
Yea AFAIR we use the maven plugin in the release script. |
|
Do you still think we need |
|
I think it is fine. The caveat is that the main branch must be kept unchanged until the release is done. |
Right. It's a restriction of the current release process. |
|
Are you good with this PR? @jbonofre |
jbonofre
left a comment
There was a problem hiding this comment.
Ok as soon as the version is bumped to SNAPSHOT after the release
|
Thanks! Let me merge it and proceed. |
No description provided.