GH-579: Add and fix LICENSE.txt and NOTICE.txt in the distributed artifacts#578
GH-579: Add and fix LICENSE.txt and NOTICE.txt in the distributed artifacts#578lidavidm merged 1 commit intoapache:mainfrom
Conversation
|
BTW, how were these generated? Or do they have to be assembled by hand? |
For this release, I did that "manually". After the release, I will add the maven tooling to at least check the content. |
| -------------------------------------------------------------------------------- | ||
| vector/src/main/java/org/apache/arrow/vector/util/IntObjectHashMap.java | ||
| vector/src/main/java/org/apache/arrow/vector/util/IntObjectMap.java | ||
| This product includes code from Netty 4.1.117.Final: |
There was a problem hiding this comment.
Is it required to include the specific version? It would be easily out of sync since the dependabot does not maintain this.
There was a problem hiding this comment.
Unfortunately (or not 😄 ), yes, It's important to specify the version of the dependency as licenses sometimes change as product versions change.
Also the NOTICE can change from a version to another.
So, it's better to document to actual version bundled in our distributed jar.
So source distribution, we should document the version where the code has been copied from.
There was a problem hiding this comment.
Thanks for the explanation! If we don't have good automation tools to keep them in sync, at least we need to make sure they are accurate in the release process.
|
I'm fixing the location and other jar resources. |
|
Should we merge PRs from Dependabot such as #584 after the next release? |
We can merge dependabot PRs, I will update this PR accordingly. That's totally fine for me. I need ~ 1 day to fix the last "jar" creation. |
|
OK. I'll merge the following PRs that were opened in this week:
Our Dependabot configuration uses "weekly". So the next PRs from Dependabot will be opened in the next week. |
|
@kou thanks ! I'm updating this PR accordingly. |
e2eac33 to
b52d085
Compare
b52d085 to
527b243
Compare
|
I'm fixing the endline thing. |
527b243 to
1a2623f
Compare
1a2623f to
7134efc
Compare
|
@jbonofre Can we merge this? |
Yes, we are good 👍 |
|
Thanks! I'll create cut an RC. |
Fixes #579.
In our distributed artifacts, especially the shading ones, we have to provide
LICENSE.txtandNOTICE.txtwith all "bundled" dependencies.@lidavidm @kou This is a draft PR as I have to fix the non-shading artifacts.