Skip to content

Commit f452b98

Browse files
eerhardtkou
authored andcommitted
ARROW-4435: Minor fixups to csharp .sln and .csproj file
1. Add .sln file to the repo. 2. Minor clean up of .csproj to move properties out of the Configuration/Platform PropertyGroups, which is the standard way of setting properties in SDK style projects. Author: Eric Erhardt <eric.erhardt@microsoft.com> Closes #3529 from eerhardt/SolutionProjectFixUp and squashes the following commits: 88a7c6ef <Eric Erhardt> Add RAT exclude for csharp sln file e9036b38 <Eric Erhardt> Minor fixups to csharp .sln and .csproj file
1 parent 753fa7e commit f452b98

File tree

3 files changed

+38
-12
lines changed

3 files changed

+38
-12
lines changed

.gitignore

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,4 +261,7 @@ __pycache__/
261261
*.pyc
262262

263263
# Project-specific
264-
artifacts/
264+
artifacts/
265+
266+
# add .sln files back because they are ignored by the root .gitignore file
267+
!*.sln

Apache.Arrow.sln

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
2+
Microsoft Visual Studio Solution File, Format Version 12.00
3+
# Visual Studio 15
4+
VisualStudioVersion = 15.0.28307.357
5+
MinimumVisualStudioVersion = 10.0.40219.1
6+
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Apache.Arrow", "src\Apache.Arrow\Apache.Arrow.csproj", "{BA6B2B0D-EAAE-4183-8A39-1B9CF571F71F}"
7+
EndProject
8+
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Apache.Arrow.Tests", "test\Apache.Arrow.Tests\Apache.Arrow.Tests.csproj", "{9CCEC01B-E67A-4726-BE72-7B514F76163F}"
9+
EndProject
10+
Global
11+
GlobalSection(SolutionConfigurationPlatforms) = preSolution
12+
Debug|Any CPU = Debug|Any CPU
13+
Release|Any CPU = Release|Any CPU
14+
EndGlobalSection
15+
GlobalSection(ProjectConfigurationPlatforms) = postSolution
16+
{BA6B2B0D-EAAE-4183-8A39-1B9CF571F71F}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
17+
{BA6B2B0D-EAAE-4183-8A39-1B9CF571F71F}.Debug|Any CPU.Build.0 = Debug|Any CPU
18+
{BA6B2B0D-EAAE-4183-8A39-1B9CF571F71F}.Release|Any CPU.ActiveCfg = Release|Any CPU
19+
{BA6B2B0D-EAAE-4183-8A39-1B9CF571F71F}.Release|Any CPU.Build.0 = Release|Any CPU
20+
{9CCEC01B-E67A-4726-BE72-7B514F76163F}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
21+
{9CCEC01B-E67A-4726-BE72-7B514F76163F}.Debug|Any CPU.Build.0 = Debug|Any CPU
22+
{9CCEC01B-E67A-4726-BE72-7B514F76163F}.Release|Any CPU.ActiveCfg = Release|Any CPU
23+
{9CCEC01B-E67A-4726-BE72-7B514F76163F}.Release|Any CPU.Build.0 = Release|Any CPU
24+
EndGlobalSection
25+
GlobalSection(SolutionProperties) = preSolution
26+
HideSolutionNode = FALSE
27+
EndGlobalSection
28+
GlobalSection(ExtensibilityGlobals) = postSolution
29+
SolutionGuid = {FD0BB617-6031-4844-B99D-B331E335B572}
30+
EndGlobalSection
31+
EndGlobal

src/Apache.Arrow/Apache.Arrow.csproj

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
1-
<Project Sdk="Microsoft.NET.Sdk">
1+
<Project Sdk="Microsoft.NET.Sdk">
22

33
<Import Project="../../build/Common.props" />
44

55
<PropertyGroup>
66
<TargetFramework>netstandard1.3</TargetFramework>
7+
<LangVersion>7.2</LangVersion>
8+
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
79
<Authors>Apache</Authors>
810
<Product>Apache Arrow library</Product>
911
<Copyright>2018 Apache Software Foundation</Copyright>
@@ -15,16 +17,6 @@
1517
<Version>0.0.1</Version>
1618
</PropertyGroup>
1719

18-
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
19-
<LangVersion>7.2</LangVersion>
20-
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
21-
</PropertyGroup>
22-
23-
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
24-
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
25-
<LangVersion>7.2</LangVersion>
26-
</PropertyGroup>
27-
2820
<ItemGroup>
2921
<PackageReference Include="System.Buffers" Version="4.5.0" />
3022
<PackageReference Include="System.Memory" Version="4.5.1" />

0 commit comments

Comments
 (0)