Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: avoid the misleading comment #4189

Merged
merged 2 commits into from
May 7, 2021
Merged

Conversation

spacewander
Copy link
Member

Also remove helpless yaml lint.

Fix #3962
Signed-off-by: spacewander spacewanderlzx@gmail.com

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Also remove helpless yaml lint.

Fix apache#3962
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander marked this pull request as ready for review May 6, 2021 09:48
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
Copy link
Member

@jbampton jbampton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you removing this test ?
Without the YAML lint test on the CI we will probably go backwards.
You can always just ignore YAML files or folders with yamllint or ignore tests in whole files.

The YAML comment syntax is configurable:

Screen Shot 2021-05-06 at 8 48 46 pm

@spacewander
Copy link
Member Author

If we ignore it, there is almost nothing left that can be checked.

I quite regard about accepting yamllint. Several months have been passed, it has been proved that the linter is helpless but causes misleading and inconvenient.

@spacewander
Copy link
Member Author

Don't try to sell us linter anymore...
We are not an experimental lab for such "modern" technologies.

@jbampton
Copy link
Member

jbampton commented May 6, 2021

You are wrong again since the comments disable rule is only one yamllint rule and there are many to check.

There are about 20 yamllint rules :)

Also most of the worlds top projects use yamllint like Apache Airflow and they know it's not helpless.

https://yamllint.readthedocs.io/en/latest/rules.html

Screen Shot 2021-05-06 at 9 15 08 pm

@spacewander spacewander merged commit 232134a into apache:master May 7, 2021
@spacewander spacewander deleted the yamllint branch May 7, 2021 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[discuss]: how to make the annotations in the config-default.yaml file clearer
4 participants