fix: init dns resolvers in stream subsystem #4186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since f914807, the connect of tcpsock was patched by using our own DNS resolvers. It relies on a dns_resolvers variable which should be initialized in init_by_lua* phase, however, the initialization step in stream sub-system is missed so once users enable the stream proxy and the tcpsock:connect is invoked with a non-IP host, Lua runtime errors will be thrown. This PR fixed this issue by initializing the DNS resolvers in the stream sub-subsystem.
membphis
approved these changes
May 6, 2021
spacewander
approved these changes
May 6, 2021
spacewander
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Since f914807, the connect of tcpsock was patched by using our own DNS
resolvers. It relies on a dns_resolvers variable which should be
initialized in init_by_lua* phase, however, the initialization step in
stream sub-system is missed so once users enable the stream proxy and
the tcpsock:connect is invoked with a non-IP host, Lua runtime errors
will be thrown.
This PR fixed this issue by initializing the DNS resolvers in the stream
sub-subsystem.
Examples
If we use the ETCD FQDN, we may see the following errors continuously.
Pre-submission checklist: