feat: rewrite handwriting validation with jsonschema #3021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacewander
force-pushed
the
schema
branch
2 times, most recently
from
3a2fec8 to
7b6c3e3
Compare
Fix apache#2967. Some plugins can't be rewritten, so I have to keep them. Signed-off-by: spacewander <spacewanderlzx@gmail.com>
membphis
reviewed
Dec 12, 2020
membphis
approved these changes
Dec 14, 2020
10 tasks
jbampton
reviewed
Dec 15, 2020
Co-authored-by: John Bampton <jbampton@users.noreply.github.com>
nic-chen
approved these changes
Dec 18, 2020
juzhiyuan
reviewed
Jul 5, 2022
|
|
||
| -- Previously, we multiply conf.timeout before storing it in etcd. | ||
| -- If the timeout is too large, we should not multiply it again. | ||
| if not (conf.timeout >= 1000 and conf.timeout % 1000 == 0) then |
There was a problem hiding this comment.
Hi @spacewander 👋 May I know why we need to use multiply here? 🤔 because both our document[1] and code comments (schema.description) says it's in second.
[1] https://apisix.apache.org/docs/apisix/next/plugins/openid-connect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2967. Some plugins can't be rewritten, so I have to keep them.
Signed-off-by: spacewander spacewanderlzx@gmail.com
What this PR does / why we need it:
Pre-submission checklist: