-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ewma balancer #2001
add ewma balancer #2001
Conversation
sync from apache/master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
real request for testing
@redynasc please take a look at the output of CI: https://github.com/apache/apisix/pull/2001/checks?check_run_id=952937828 + luacheck -q apisix
Checking apisix/balancer/ewma.lua 7 warnings
apisix/balancer/ewma.lua:146:16: unused function calculate_slow_start_ewma
apisix/balancer/ewma.lua:176:11: unused variable k
apisix/balancer/ewma.lua:176:13: unused variable _
make: *** [lint] Error 1
apisix/balancer/ewma.lua:192:21: variable ewma_score is never accessed
apisix/balancer/ewma.lua:196:101: line is too long (102 > 100)
apisix/balancer/ewma.lua:206:5: right side of assignment has less values than left side expects
apisix/balancer/ewma.lua:225:101: line is too long (102 > 100)
+ exit 1 |
@redynasc if we have fixed them, we can click the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems much better now.
@membphis please take a look, and I think we need more test cases, WDYT? |
@redynasc For the code of other projects, we cannot add ASF header, please take a look at https://github.com/apache/skywalking/blob/master/LICENSE#L204, which is the correct way to deal with license issue. |
@redynasc we need more test cases |
@redynasc ping |
@redynasc any update? |
add one new test case,It is difficult to add more test items, any suggestions? |
@redynasc it seems that the new test case is unstable. we need to fix this before we merge this PR
|
Do I need to care about the following errors in test? |
the license issue is not fixed, which is MUST fixed before next release. |
I added the "Apache ApiSix Subcomponent" section to the license file |
I will help to fix license issue after this PR merged.
Thanks,
Ming Wen
Twitter: _WenMing
redynasc <notifications@github.com> 于2020年8月27日周四 上午10:52写道:
… the license issue is not fixed, which is MUST fixed before next release.
I added the "Apache ApiSix Subcomponent" section to the license file
I don't know how to solve this problem and need help
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2001 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGJZBKYKTU64GZEOPGIPFILSCXC6NANCNFSM4PVUIBEA>
.
|
font{
line-height: 1.6;
}
ul,ol{
padding-left: 20px;
list-style-position: inside;
}
Thank you very much.
ifonly.dgg
ifonly.dgg@gmail.com
签名由
网易邮箱大师
定制
On 8/27/2020 11:56,Wen Ming<notifications@github.com> wrote:
I will help to fix license issue after this PR merged.
Thanks,
Ming Wen
Twitter: _WenMing
redynasc <notifications@github.com> 于2020年8月27日周四 上午10:52写道:
the license issue is not fixed, which is MUST fixed before next release.
I added the "Apache ApiSix Subcomponent" section to the license file
I don't know how to solve this problem and need help
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2001 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGJZBKYKTU64GZEOPGIPFILSCXC6NANCNFSM4PVUIBEA>
.
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.
|
@redynasc merged, many thx |
What this PR does / why we need it:
ewma is a different balancing implementation that will generate a weight for every backend IP based on the last server response time, basically it tries to dispatch more requests to the backends that reply faster, supposing that they are less loaded.
fix #1996
Pre-submission checklist: