Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request help: healthcheck plugin can support passive checks alone ? #4959

Closed
Donghui0 opened this issue Sep 1, 2021 · 5 comments
Closed
Labels

Comments

@Donghui0
Copy link
Contributor

Donghui0 commented Sep 1, 2021

Issue description

healthcheck plugin can support passive checks alone? like nginx upstream processing method. After exceeding the set failure threshold(max_fails), the node is removed, after a period of time, try again.

relate issue: apache/apisix-ingress-controller#632

Environment

  • apisix version (cmd: apisix version):
  • OS (cmd: uname -a):
  • OpenResty / Nginx version (cmd: nginx -V or openresty -V):
  • etcd version, if have (cmd: run curl http://127.0.0.1:9090/v1/server_info to get the info from server-info API):
  • apisix-dashboard version, if have:
  • luarocks version, if the issue is about installation (cmd: luarocks --version):
@tzssangglass
Copy link
Member

After exceeding the set failure threshold(max_fails), the node is removed, after a period of time, try again.

I think active health checks can do this

@Donghui0
Copy link
Contributor Author

Donghui0 commented Sep 2, 2021

After exceeding the set failure threshold(max_fails), the node is removed, after a period of time, try again.

I think active health checks can do this

When there are many endpoint nodes, such as between 300 and 500. And when the number of k8s services is relatively large, active check will have higher CPU consumption.

@tzssangglass
Copy link
Member

not supported yet.

but I think it's a very useful feature, my initial ideas are as below:

  1. only passive health checks are enabled by default
  2. passive health check finds that the upstream node has failed and marks the node as unhealthy
  3. enable active health checks to probe unhealthy nodes
  4. once an unhealthy node is found to be recovered by active health checks, mark the node as healthy and stop active health checks on this node

can you send an email to discuss this at dev@apisix.apache.org ?

@github-actions
Copy link

This issue has been marked as stale due to 350 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Aug 18, 2022
@github-actions
Copy link

github-actions bot commented Sep 2, 2022

This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time.

@github-actions github-actions bot closed this as completed Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants