-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: filter useless pod update event #894
Conversation
Codecov Report
@@ Coverage Diff @@
## master #894 +/- ##
==========================================
+ Coverage 32.05% 32.06% +0.01%
==========================================
Files 70 70
Lines 7740 7755 +15
==========================================
+ Hits 2481 2487 +6
- Misses 4984 4993 +9
Partials 275 275
Continue to review full report at Codecov.
|
Flaky test #869 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic is OK.
@gxthrj It seems that what you submitted is not an approval, but just a comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
re-run CI test.
The e2e-test failed. Similar error as before. Nothing to with this pr. @tao12345666333 |
Yep. Flaky test #869 |
It's green |
Type of change:
What this PR does / why we need it:
onUpdate
will get pod update event everyresync_interval
seconds/hours. It's unnecessary.Pre-submission checklist: