Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter useless pod update event #894

Merged
merged 1 commit into from
Mar 3, 2022
Merged

fix: filter useless pod update event #894

merged 1 commit into from
Mar 3, 2022

Conversation

nayihz
Copy link
Contributor

@nayihz nayihz commented Mar 2, 2022

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

onUpdate will get pod update event every resync_interval seconds/hours. It's unnecessary.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

Codecov Report

Merging #894 (bdef0c9) into master (77383b8) will increase coverage by 0.01%.
The diff coverage is 22.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #894      +/-   ##
==========================================
+ Coverage   32.05%   32.06%   +0.01%     
==========================================
  Files          70       70              
  Lines        7740     7755      +15     
==========================================
+ Hits         2481     2487       +6     
- Misses       4984     4993       +9     
  Partials      275      275              
Impacted Files Coverage Δ
pkg/ingress/apisix_consumer.go 0.00% <0.00%> (ø)
pkg/ingress/apisix_pluginconfig.go 0.00% <0.00%> (ø)
pkg/ingress/apisix_route.go 0.00% <0.00%> (ø)
pkg/ingress/apisix_tls.go 0.00% <0.00%> (ø)
pkg/ingress/apisix_upstream.go 0.00% <0.00%> (ø)
pkg/ingress/compare.go 0.00% <0.00%> (ø)
pkg/ingress/endpoint.go 0.00% <0.00%> (ø)
pkg/ingress/endpointslice.go 0.00% <0.00%> (ø)
pkg/ingress/gateway.go 0.00% <0.00%> (ø)
pkg/ingress/ingress.go 6.76% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d25525...bdef0c9. Read the comment docs.

@tao12345666333 tao12345666333 requested review from tokers, gxthrj, lingsamuel and tao12345666333 and removed request for tokers and gxthrj March 2, 2022 06:19
@tao12345666333
Copy link
Member

Flaky test #869

Copy link
Contributor

@gxthrj gxthrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic is OK.

@lingsamuel
Copy link
Member

@gxthrj It seems that what you submitted is not an approval, but just a comment.

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

re-run CI test.

@nayihz
Copy link
Contributor Author

nayihz commented Mar 3, 2022

The e2e-test failed. Similar error as before. Nothing to with this pr. @tao12345666333

@tao12345666333
Copy link
Member

Yep. Flaky test #869
This issue has not yet been reproduced locally. re-run 😿

@tao12345666333
Copy link
Member

It's green

@tao12345666333 tao12345666333 merged commit bbaba6f into apache:master Mar 3, 2022
@nayihz nayihz deleted the filter-pod-update-event branch March 3, 2022 06:44
tao12345666333 pushed a commit to tao12345666333/ingress-controller that referenced this pull request Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants