Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

help request: How to define keepalive through ApisixUpstream_ The idle of the pool_ Timeout #1883

Open
jinjianming opened this issue Jul 5, 2023 · 7 comments · May be fixed by #2310
Open
Assignees
Labels

Comments

@jinjianming
Copy link

Description

apiVersion:  apisix.apache.org/v2
kind: ApisixUpstream
metadata:
  name: nginx
spec:
  loadbalancer:
    type: roundrobin
  keepalive_pool:
    idle_timeout: 90s

Environment

  • APISIX version (run apisix version):
  • Operating system (run uname -a):
  • OpenResty / Nginx version (run openresty -V or nginx -V):
  • etcd version, if relevant (run curl http://127.0.0.1:9090/v1/server_info):
  • APISIX Dashboard version, if relevant:
  • Plugin runner version, for issues related to plugin runners:
  • LuaRocks version, for installation issues (run luarocks --version):
@lingsamuel lingsamuel transferred this issue from apache/apisix Jul 5, 2023
@Revolyssup
Copy link
Contributor

@tao12345666333 Currently ApisixUpstream CR doesn't support this. Should I add the support ?

@tao12345666333
Copy link
Member

According to the schema specification of APISIX Upstream, we can add this field.
https://github.com/apache/apisix/blob/f2337f25d4bdbe7291810f36c0fbedd5cea8d29d/apisix/schema_def.lua#L417-L436

If you are willing to add this feature, welcome to submit a PR. @jinjianming

This is an issue that is very suitable for beginners to contribute.

@tao12345666333 tao12345666333 added the good first issue Good for newcomers label Jul 5, 2023
@tao12345666333
Copy link
Member

This is an issue that is very suitable for beginners to contribute.

@Revolyssup as I said above, let's leave this for beginners

@AHNakbari
Copy link

can you kindly assign me this issue?

@lingsamuel
Copy link
Member

@splenta22 assigned, thanks!

@slayer321
Copy link

Hey @tao12345666333 , I'm not sure If @AHNakbari is still working on this Issue. If not can you Please assign it to me

@slayer321
Copy link

Hey @Revolyssup , I'm working on this issue and wanted to understand how do you folks generate the CRD's? I tried using below command

controller-gen crd paths=./pkg/kube/apisix/apis/... output:crd:dir=./samples/deploy/crd/v1

But I was generating the whole different file for me.

Also I cannot find and make command for it though I found update-codegen with generated other things.

@slayer321 slayer321 linked a pull request Oct 15, 2024 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants