feat: support APISIX_PROFILE for env-specific configuration #2293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2293 +/- ##
==========================================
+ Coverage 65.08% 69.87% +4.79%
==========================================
Files 184 184
Lines 7274 7280 +6
Branches 829 830 +1
==========================================
+ Hits 4734 5087 +353
+ Misses 2256 1898 -358
- Partials 284 295 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
cc @zaunist @Baoyuantop to have a review |
nic-chen
approved these changes
Jan 29, 2022
Baoyuantop
approved these changes
Jan 30, 2022
juzhiyuan
approved these changes
Jan 31, 2022
|
cc @Baoyuantop please help review this, Thanks. |
starsz
approved these changes
Feb 6, 2022
hongbinhsu
pushed a commit
to fitphp/apix-dashboard
that referenced
this pull request
Feb 7, 2022
* master: feat: support APISIX_PROFILE for env-specific configuration (apache#2293) style: remove extra margin value (apache#2300)
hongbinhsu
pushed a commit
to fitphp/apix-dashboard
that referenced
this pull request
Feb 23, 2022
* upstream: feat: support APISIX_PROFILE for env-specific configuration (apache#2293)
hongbinhsu
pushed a commit
to fitphp/apix-dashboard
that referenced
this pull request
Feb 23, 2022
* upstream: feat: support APISIX_PROFILE for env-specific configuration (apache#2293)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
This is a follow up to this PR by @kevinw66.
The original PR was not updated for a long time, and also after trying, I could not directly create the commit to finish it, so I created a new PR which directly used the results of @kevinw66 and tagged the author.
I added some additional startup logs to it and also added test cases.
Related issues
continue: #2238
Checklist: