chore: improve Upstream/CodeMirror #1707

juzhiyuan · 2021-04-04T09:21:27Z

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

Bugfix
New feature provided
Improve performance
Backport patches

What changes will this PR take into?

Please update this section with a detailed description.

use UpperCase for JSON/YAML selector in CodeMirror
added more description for Upstream List
added more proper fields description for Upstream Form (Chinese: Done; English: TODO)
added retries field for health check
added default values for health check

Related issues

None

Checklist:

Did you explain what problem does this PR solve? Or what new features have been added?
Have you added corresponding test cases?
Have you modified the corresponding document?
Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

codecov-io · 2021-04-04T09:23:10Z

Codecov Report

Merging #1707 (3fb0ea6) into master (8494e45) will increase coverage by 0.17%.
The diff coverage is 45.45%.

@@            Coverage Diff             @@
##           master    #1707      +/-   ##
==========================================
+ Coverage   71.87%   72.04%   +0.17%     
==========================================
  Files         130      130              
  Lines        5660     5649      -11     
  Branches      661      648      -13     
==========================================
+ Hits         4068     4070       +2     
+ Misses       1352     1335      -17     
- Partials      240      244       +4

Flag	Coverage Δ
backend-e2e-test	`62.28% <ø> (+0.19%)`	⬆️
backend-e2e-test-ginkgo	`48.43% <ø> (+0.06%)`	⬆️
backend-unit-test	`52.29% <ø> (ø)`
frontend-e2e-test	`72.69% <45.45%> (+0.15%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
web/src/pages/Consumer/List.tsx	`90.00% <ø> (ø)`
web/src/pages/Route/List.tsx	`84.61% <ø> (ø)`
web/src/pages/Service/List.tsx	`97.43% <ø> (ø)`
web/src/pages/Upstream/components/Step1.tsx	`100.00% <ø> (ø)`
web/src/components/Plugin/PluginDetail.tsx	`52.72% <16.66%> (ø)`
web/src/components/Upstream/UpstreamForm.tsx	`63.24% <42.85%> (+1.70%)`	⬆️
web/src/components/RawDataEditor/RawDataEditor.tsx	`37.73% <50.00%> (ø)`
web/src/pages/Upstream/Create.tsx	`79.41% <50.00%> (ø)`
web/src/components/Upstream/constant.ts	`100.00% <100.00%> (ø)`
web/src/pages/Upstream/List.tsx	`90.00% <100.00%> (ø)`
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8494e45...3fb0ea6. Read the comment docs.

juzhiyuan · 2021-04-05T15:43:03Z

as for default values, we need to refer to https://github.com/api7/lua-resty-healthcheck/tree/master/docs , I will file a new PR to do that.

juzhiyuan · 2021-04-05T22:42:08Z

@LiteSun

I have some doubts:

Why FE doesn't have coverage 😳
I don't change backend files, but this PR reduces some coverage.

juzhiyuan · 2021-04-05T23:08:42Z

@iamayushdas @KishaniKandasamy @stu01509 You could also review this PR :)

stu01509 · 2021-04-05T23:10:14Z

@iamayushdas @KishaniKandasamy @stu01509 You could also review this PR :)

Sure 😃

iamayushdas

👍🏻

web/src/components/Upstream/UpstreamForm.tsx

web/src/components/RawDataEditor/locales/en-US.ts

web/src/locales/en-US/component.ts

KishaniKandasamy · 2021-04-06T03:50:30Z

@iamayushdas @KishaniKandasamy @stu01509 You could also review this PR :)

👍🏻

web/src/components/RawDataEditor/locales/zh-CN.ts

juzhiyuan · 2021-04-06T05:14:39Z

Hi, I noticed we have comments all about CodeMirror, how about adding some descriptions for this component? I don't have a better name yet, I would still prefer keeping using CodeMirror than Create with Editor. What's your opinion?

BTW, how about other changes in this PR? Do they make sense to you?

juzhiyuan · 2021-04-06T05:15:35Z

Oops! When I want to select more reviewers on GitHub app, it unselect some of reviewers.

web/src/components/Upstream/UpstreamForm.tsx

qian0817 · 2021-04-06T06:57:01Z

web/src/pages/Upstream/List.tsx

@@ -136,12 +136,11 @@ const Page: React.FC = () => {
            <PlusOutlined />
            {formatMessage({ id: 'component.global.create' })}
          </Button>,
-          <Button type="primary" onClick={() => {
+          <Button type="default" onClick={() => {


I think the original way looks better.
At the same time, If really need to do this, also need to modify the style of other pages.

not sure if we really need the primary button here 🤔

juzhiyuan · 2021-04-06T15:31:13Z

Hi all, except those comments, any comments about those changes?

codecov-commenter · 2024-10-30T22:17:38Z

Codecov Report

Attention: Patch coverage is 45.45455% with 12 lines in your changes missing coverage. Please review.

Project coverage is 72.04%. Comparing base (8494e45) to head (3fb0ea6).
Report is 419 commits behind head on master.

Files with missing lines	Patch %	Lines
web/src/components/Plugin/PluginDetail.tsx	16.66%	5 Missing ⚠️
web/src/components/Upstream/UpstreamForm.tsx	42.85%	4 Missing ⚠️
web/src/components/RawDataEditor/RawDataEditor.tsx	50.00%	2 Missing ⚠️
web/src/pages/Upstream/Create.tsx	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1707      +/-   ##
==========================================
+ Coverage   71.87%   72.04%   +0.17%     
==========================================
  Files         130      130              
  Lines        5660     5649      -11     
  Branches      661      648      -13     
==========================================
+ Hits         4068     4070       +2     
+ Misses       1352     1335      -17     
- Partials      240      244       +4

Flag	Coverage Δ
backend-e2e-test	`47.79% <ø> (+0.25%)`	⬆️
backend-e2e-test-ginkgo	`48.43% <ø> (+0.06%)`	⬆️
backend-unit-test	`52.29% <ø> (ø)`
frontend-e2e-test	`72.69% <45.45%> (+0.15%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

juzhiyuan added 2 commits April 4, 2021 17:16

chore: use UpperCase for JSON/YAML

68f4fb8

ui: improve i18n for Upstream Form

a0c212f

juzhiyuan marked this pull request as draft April 4, 2021 09:21

juzhiyuan added 6 commits April 4, 2021 23:06

support retries field & update fields description

1d4b07d

doc: added some tooltips for fields

25dc8a5

Merge branch 'master' into feat-upstream

59fe982

doc: added more tips on Health Check

ec20140

doc: added tips on Upstream List

f16f52c

doc: support English

96474a3

juzhiyuan marked this pull request as ready for review April 5, 2021 15:43

juzhiyuan added 3 commits April 5, 2021 23:57

fix: FE E2E

c96ec43

doc: use algorithm instead of type

702843a

fix: test for Upstream

fc8f745

juzhiyuan requested review from LiteSun, liuxiran, bzp2010, Jaycean and imjoey April 5, 2021 22:35

juzhiyuan mentioned this pull request Apr 5, 2021

feat: autocomplete when people input http header #1679

Merged

8 tasks

iamayushdas approved these changes Apr 5, 2021

View reviewed changes

stu01509 reviewed Apr 5, 2021

View reviewed changes

web/src/components/Upstream/UpstreamForm.tsx Outdated Show resolved Hide resolved

liuxiran reviewed Apr 6, 2021

View reviewed changes

web/src/components/RawDataEditor/locales/en-US.ts Outdated Show resolved Hide resolved

LiteSun reviewed Apr 6, 2021

View reviewed changes

web/src/locales/en-US/component.ts Show resolved Hide resolved

KishaniKandasamy reviewed Apr 6, 2021

View reviewed changes

web/src/components/RawDataEditor/locales/zh-CN.ts Outdated Show resolved Hide resolved

juzhiyuan requested review from LiteSun, liuxiran, membphis, moonming and Yiyiyimu April 6, 2021 05:16

qian0817 reviewed Apr 6, 2021

View reviewed changes

juzhiyuan added 4 commits April 7, 2021 00:11

chore: use Raw Data Editor instead

668bcab

chore: use Raw Data Editor instead

1305819

chore: use Raw Data Editor instead

32e1280

fix: update the i18n for host field

842b906

bzp2010 approved these changes Apr 7, 2021

View reviewed changes

juzhiyuan added 2 commits April 7, 2021 08:54

docs: update i18n in English for upstream

7d47caa

docs: use Hostname instead of Host

3fb0ea6

Yiyiyimu approved these changes Apr 7, 2021

View reviewed changes

KishaniKandasamy approved these changes Apr 7, 2021

View reviewed changes

LiteSun approved these changes Apr 7, 2021

View reviewed changes

moonming approved these changes Apr 7, 2021

View reviewed changes

liuxiran approved these changes Apr 7, 2021

View reviewed changes

juzhiyuan merged commit 2c158a1 into master Apr 7, 2021

juzhiyuan deleted the feat-upstream branch April 7, 2021 04:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: improve Upstream/CodeMirror #1707

chore: improve Upstream/CodeMirror #1707

juzhiyuan commented Apr 4, 2021 •

edited

Loading

codecov-io commented Apr 4, 2021 •

edited

Loading

juzhiyuan commented Apr 5, 2021

juzhiyuan commented Apr 5, 2021

juzhiyuan commented Apr 5, 2021

stu01509 commented Apr 5, 2021

iamayushdas left a comment

KishaniKandasamy commented Apr 6, 2021

juzhiyuan commented Apr 6, 2021

juzhiyuan commented Apr 6, 2021

qian0817 Apr 6, 2021

juzhiyuan Apr 6, 2021

juzhiyuan commented Apr 6, 2021

codecov-commenter commented Oct 30, 2024

chore: improve Upstream/CodeMirror #1707

chore: improve Upstream/CodeMirror #1707

Conversation

juzhiyuan commented Apr 4, 2021 • edited Loading

codecov-io commented Apr 4, 2021 • edited Loading

Codecov Report

juzhiyuan commented Apr 5, 2021

juzhiyuan commented Apr 5, 2021

juzhiyuan commented Apr 5, 2021

stu01509 commented Apr 5, 2021

iamayushdas left a comment

Choose a reason for hiding this comment

KishaniKandasamy commented Apr 6, 2021

juzhiyuan commented Apr 6, 2021

juzhiyuan commented Apr 6, 2021

qian0817 Apr 6, 2021

Choose a reason for hiding this comment

juzhiyuan Apr 6, 2021

Choose a reason for hiding this comment

juzhiyuan commented Apr 6, 2021

codecov-commenter commented Oct 30, 2024

Codecov Report

juzhiyuan commented Apr 4, 2021 •

edited

Loading

codecov-io commented Apr 4, 2021 •

edited

Loading