Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(be): Schema File Minor problems left #1412

Merged
merged 1 commit into from
Feb 1, 2021
Merged

fix(be): Schema File Minor problems left #1412

merged 1 commit into from
Feb 1, 2021

Conversation

Jaycean
Copy link
Member

@Jaycean Jaycean commented Feb 1, 2021 •
edited by nic-chen
Loading

Please answer these questions before submitting a pull request

Bugfix

#986 (comment)
This comment modification status code involves many modifications, so don't modify it first.

imjoey
imjoey approved these changes Feb 1, 2021
View reviewed changes
Copy link
Member

@imjoey imjoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks @Jaycean .

@imjoey imjoey merged commit 6e98820 into apache:master Feb 1, 2021
@Jaycean Jaycean deleted the fix_schema_file_minor_problems_left branch February 3, 2021 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nic-chen nic-chen nic-chen approved these changes

@tokers tokers tokers approved these changes

@imjoey imjoey imjoey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

style: code optimization for api/filters/schema.go
4 participants
@Jaycean @imjoey @tokers @nic-chen