-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Improve Bigtable operator documentation #61277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
shahar1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nitpicks, overall LGTM!
Added clearer explanations for Bigtable operators and removed duplicate sentences for better readability.
KamranImaaz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BigtableTableReplicationCompletedSensor section is a sensor specific documentation not a part of operator documentation. This section should be moved to Sensor specific documentation.
| Use the :class:`~airflow.providers.google.cloud.sensors.bigtable.BigtableTableReplicationCompletedSensor` | ||
| to wait for the table to replicate fully. | ||
|
|
||
| This sensor periodically checks the replication status and blocks execution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this entire BigtableTableReplicationCompletedSensor as it is a part of Sensor file.
Added clearer explanations for Bigtable operators and removed duplicate sentences for better readability.
Closes #61269
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.