-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Fix slots negative infinity #61140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix slots negative infinity #61140
Conversation
mentioned about deprication of project_id parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, looking good overall.
Just a few suggetions, and CI need fixing.
airflow-core/src/airflow/api_fastapi/core_api/datamodels/pools.py
Outdated
Show resolved
Hide resolved
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_pools.py
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/api_fastapi/core_api/datamodels/pools.py
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/api_fastapi/core_api/datamodels/pools.py
Outdated
Show resolved
Hide resolved
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_pools.py
Outdated
Show resolved
Hide resolved
Thanks for your review. will update accordingly... |
jason810496
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems generative AI tooling was used in the PR.
If it was used, please add the following question and checkbox in the PR description.
Thanks!
airflow/.github/PULL_REQUEST_TEMPLATE.md
Lines 20 to 32 in e061647
| ##### Was generative AI tooling used to co-author this PR? | |
| <!-- | |
| If generative AI tooling has been used in the process of authoring this PR, please | |
| change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by". | |
| --> | |
| - [ ] Yes (please specify the tool below) | |
| <!-- | |
| Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) | |
| --> |
Fix #61115
Updated Pools to accept -1 or Infinity to prevent 500 Error.
Add API tests for POST/PATCH with unlimited slots
Was generative AI tooling used to co-author this PR?
Github Copilot