Optimize exception handling in GCP bigtable operator and hook

[KamranImaaz]

Fixes #60687

[KamranImaaz]

@shahar1 due to a small mistake i accidentally pushed the all commits and got auto assigned reviewers. Sorry for that.

[shahar1]

Not bad!
Please fix according to the comments.

[KamranImaaz]

And Also Shahar this we are using everywhere in the operator instead of that we can use instance.exists() in one line in hooks right??

        instance = hook.get_instance(project_id=self.project_id, instance_id=self.instance_id)
        if not instance:
            raise AirflowException(f"Dependency: instance '{self.instance_id}' does not exist.")

[shahar1]

instance = hook.get_instance(project_id=self.project_id, instance_id=self.instance_id)

You may encapsulate it in the hook where applicable

[KamranImaaz]

Okay Sure

[KamranImaaz]

I have updated the code according to your comments. Please have a view.

[KamranImaaz]

@shahar1 all the CI checks have passed. your approval would be great here

[shahar1]

Looks much better!!!
One last thing to do is to update all docstrings of the operators and hooks according to the changes (for example, "Raises google.api_core.exceptions.NotFound" is not relevant anymore for the modified operators)

[KamranImaaz]

Thanks Shahar for your review.

[KamranImaaz]

I created an issue for that yesterday inorder to get your approval before opening a PR. Please have a look #61269

[shahar1]

I created an issue for that yesterday inorder to get your approval before opening a PR. Please have a look #61269

I wasn't talking about the documentation in bigtable.rst (which indeed should be updated), but the docstring which is part of the method.
Take a look at: https://github.com/KamranImaaz/apache.airflow/blob/79fb50b12d738f75f25f29717b92a16b75cb22dc/providers/google/src/airflow/providers/google/cloud/hooks/bigtable.py#L245

After your changes this won't be true anymore (same goes for strings in the other methods).
I hope that it's clearer now.

[KamranImaaz]

Oh Okay. I misunderstood it. Now I get it. I will update it

[KamranImaaz]

BTW, I already created a branch and was working on it for #61269 seems it already got assigned. Never mind. Let the other person do the work :)