Skip to content

Remove unused method is_default_pool in Pool model #61084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vincbeck merged 1 commit into from
Jan 27, 2026
Merged

Remove unused method is_default_pool in Pool model #61084

vincbeck merged 1 commit into from
Jan 27, 2026

Conversation

@vincbeck
Copy link
Contributor

@vincbeck vincbeck commented Jan 26, 2026 •
edited
Loading

While working on pools, I found out this method is unused in the codebase.

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)
  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added the area:API Airflow's REST/HTTP API label Jan 26, 2026
@vincbeck vincbeck changed the title Remove unused methods in Pool model Remove unused method is_default_pool in Pool model Jan 26, 2026
@vincbeck vincbeck force-pushed the vincbeck/pool_unused branch from c611580 to 3d73511 Compare January 26, 2026 19:55
pierrejeambrun
pierrejeambrun approved these changes Jan 27, 2026
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@pierrejeambrun pierrejeambrun added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Jan 27, 2026
@pierrejeambrun pierrejeambrun added this to the Airflow 3.1.7 milestone Jan 27, 2026
@vincbeck vincbeck merged commit dfa9356 into apache:main Jan 27, 2026
121 of 122 checks passed
@vincbeck vincbeck deleted the vincbeck/pool_unused branch January 27, 2026 15:41
github-actions bot pushed a commit that referenced this pull request Jan 27, 2026
@vincbeck
[v3-1-test] Remove unused method is_default_pool in Pool model (#61084
cefe18b 
)

(cherry picked from commit dfa9356)

Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Jan 27, 2026

Backport successfully created: v3-1-test

Status Branch Result
✅ v3-1-test PR Link

vincbeck added a commit that referenced this pull request Jan 27, 2026
@github-actions @vincbeck
[v3-1-test] Remove unused method is_default_pool in Pool model (#61084
7a42423 
) (#61128)

(cherry picked from commit dfa9356)

Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
shreyas-dev pushed a commit to shreyas-dev/airflow that referenced this pull request Jan 29, 2026
@vincbeck @shreyas-dev
Remove unused method is_default_pool in Pool model (apache#61084)
1ae1ba8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierrejeambrun pierrejeambrun pierrejeambrun approved these changes

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy

@rawwar rawwar Awaiting requested review from rawwar

@jason810496 jason810496 Awaiting requested review from jason810496

@XD-DENG XD-DENG Awaiting requested review from XD-DENG XD-DENG is a code owner

@ashb ashb Awaiting requested review from ashb ashb is a code owner

Assignees

No one assigned

Labels

area:API Airflow's REST/HTTP API backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Milestone

Airflow 3.1.7

Development

Successfully merging this pull request may close these issues.

2 participants

@vincbeck @pierrejeambrun