[v3-1-test] Move row count and display toggle into DataTable (#57680) #60639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add result count to dag run and ti tabs * conditionally render filter count if count > 0 * remove unused translate * add optional ToggleTableDisplay element to DataTable component * move ToggleTableDisplay to DataTable * make datatable showRowCountHeading default to true and change modelName to required. update datatable users to disable the heading based on if they have pluralizable model keys (cherry picked from commit f59198a) Co-authored-by: Cameron Billy <87656130+cmbilly8@users.noreply.github.com>
pierrejeambrun
requested review from
bbovenzi,
jscheffl,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
85 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add result count to dag run and ti tabs
conditionally render filter count if count > 0
remove unused translate
add optional ToggleTableDisplay element to DataTable component
move ToggleTableDisplay to DataTable
make datatable showRowCountHeading default to true and change modelName to required. update datatable users to disable the heading based on if they have pluralizable model keys
(cherry picked from commit f59198a)
Co-authored-by: Cameron Billy 87656130+cmbilly8@users.noreply.github.com