Skip to content

Conversation

@vighneshtule
Copy link
Contributor

This PR updates chart/values.yaml to explicitly clarify the versioning support for Ingress configurations:

  • ingress.web: Only used for Airflow 2.x (Webserver).
  • ingress.apiServer: Only used for Airflow 3+ (API Server).

This clarifies usage for users deploying Helm charts across different Airflow versions and prevents confusion when ingress.web values are ignored in Airflow 3 setups.

Related Issue:
closes: #53611

Was generative AI tooling used to co-author this PR?

  • Yes

@boring-cyborg
Copy link

boring-cyborg bot commented Jan 12, 2026

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Jan 12, 2026
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement of docs!

@jscheffl jscheffl added this to the Airflow Helm Chart 1.19.0 milestone Jan 12, 2026
@vighneshtule
Copy link
Contributor Author

Thank you, I would love to contribute more :)

@jscheffl
Copy link
Contributor

Thank you, I would love to contribute more :)

Anytime!

@jscheffl jscheffl merged commit fe73400 into apache:main Jan 12, 2026
96 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 12, 2026

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Helm values.yaml

3 participants