-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Docs: Clarify ingress settings for Airflow 2 vs 3 in values.yaml #60434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the improvement of docs!
|
Thank you, I would love to contribute more :) |
Anytime! |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
This PR updates chart/values.yaml to explicitly clarify the versioning support for Ingress configurations:
ingress.web: Only used for Airflow 2.x (Webserver).ingress.apiServer: Only used for Airflow 3+ (API Server).This clarifies usage for users deploying Helm charts across different Airflow versions and prevents confusion when
ingress.webvalues are ignored in Airflow 3 setups.Related Issue:
closes: #53611
Was generative AI tooling used to co-author this PR?