Skip to content

Correct the access for the externalLogUrl #60412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shubhamraj-git merged 2 commits into from
Jan 13, 2026
Merged

Correct the access for the externalLogUrl #60412

shubhamraj-git merged 2 commits into from
Jan 13, 2026

Conversation

@shubhamraj-git
Copy link
Contributor

@shubhamraj-git shubhamraj-git commented Jan 12, 2026

External log URL retrieval should require the Task Logs permission similar to Log content. Users without Task Logs permission should not be able to access any log-related endpoints.

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@shubhamraj-git shubhamraj-git requested a review from potiuk January 12, 2026 15:24
@boring-cyborg boring-cyborg bot added the area:API Airflow's REST/HTTP API label Jan 12, 2026
jason810496
jason810496 reviewed Jan 12, 2026
View reviewed changes
Copy link
Member

@jason810496 jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!
It would be nice to update the corresponding tests, thanks!

pierrejeambrun
pierrejeambrun approved these changes Jan 13, 2026
View reviewed changes
@shubhamraj-git
Copy link
Contributor Author

shubhamraj-git commented Jan 13, 2026

Thanks @jason810496 and @pierrejeambrun for the review.
@jason810496 If no further question, Can I go ahead and merge this?

@potiuk
Copy link
Member

potiuk commented Jan 13, 2026

Thanks @jason810496 and @pierrejeambrun for the review. @jason810496 If no further question, Can I go ahead and merge this?

feel free :)

@potiuk potiuk added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Jan 13, 2026
@potiuk potiuk added this to the Airflow 3.1.7 milestone Jan 13, 2026
@shubhamraj-git shubhamraj-git merged commit 934409f into apache:main Jan 13, 2026
129 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 13, 2026
@shubhamraj-git
[v3-1-test] Correct the access for the externalLogUrl (#60412)
fce8d12 
(cherry picked from commit 934409f)

Co-authored-by: Shubham Raj <48172486+shubhamraj-git@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Jan 13, 2026

Backport successfully created: v3-1-test

Status Branch Result
✅ v3-1-test PR Link

shubhamraj-git added a commit that referenced this pull request Jan 14, 2026
@github-actions @shubhamraj-git
[v3-1-test] Correct the access for the externalLogUrl (#60412) (#60479)
0fcac2d 
(cherry picked from commit 934409f)

Co-authored-by: Shubham Raj <48172486+shubhamraj-git@users.noreply.github.com>
ephraimbuddy pushed a commit that referenced this pull request Jan 14, 2026
@github-actions @shubhamraj-git @ephraimbuddy
[v3-1-test] Correct the access for the externalLogUrl (#60412) (#60479)
a1212c3 
(cherry picked from commit 934409f)

Co-authored-by: Shubham Raj <48172486+shubhamraj-git@users.noreply.github.com>
ephraimbuddy pushed a commit that referenced this pull request Jan 16, 2026
@github-actions @shubhamraj-git @ephraimbuddy
[v3-1-test] Correct the access for the externalLogUrl (#60412) (#60479)
f02a681 
(cherry picked from commit 934409f)

Co-authored-by: Shubham Raj <48172486+shubhamraj-git@users.noreply.github.com>
jason810496 pushed a commit to jason810496/airflow that referenced this pull request Jan 22, 2026
@shubhamraj-git @jason810496
Correct the access for the externalLogUrl (apache#60412)
236d181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jason810496 jason810496 jason810496 left review comments

@potiuk potiuk potiuk approved these changes

@pierrejeambrun pierrejeambrun pierrejeambrun approved these changes

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner

@rawwar rawwar Awaiting requested review from rawwar rawwar is a code owner

@bugraoz93 bugraoz93 Awaiting requested review from bugraoz93 bugraoz93 is a code owner

@choo121600 choo121600 Awaiting requested review from choo121600 choo121600 is a code owner

Assignees

No one assigned

Labels

area:API Airflow's REST/HTTP API backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Milestone

Airflow 3.1.7

Development

Successfully merging this pull request may close these issues.

4 participants

@shubhamraj-git @potiuk @pierrejeambrun @jason810496