-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Add transport parameter to CloudRunHook and CloudRunExecuteJobOperator #60394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+90
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for API requests. This allows users to specify 'rest' or 'grpc' transport methods across CloudRunHook, CloudRunAsyncHook, CloudRunExecuteJobOperator, and CloudRunJobFinishedTrigger classes
uranusjr
reviewed
Jan 12, 2026
providers/google/src/airflow/providers/google/cloud/triggers/cloud_run.py
Outdated
Show resolved
Hide resolved
…rt method in CloudRunHook, CloudRunAsyncHook, CloudRunExecuteJobOperator, and CloudRunJobFinishedTrigger classes. Adjusted related tests to reflect this change
…, defaulting to 'grpc' for backward compatibility. Adjusted related tests to accommodate this change
olegkachur-e
suggested changes
Jan 13, 2026
providers/google/tests/unit/google/cloud/hooks/test_cloud_run.py
Outdated
Show resolved
Hide resolved
…CloudRunExecuteJobOperator to allow None as a valid option, enabling automatic transport selection. Updated related tests to validate this change
0bb4e52 to
8b604fd
Compare
shahar1
reviewed
Jan 24, 2026
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM with a small comment - please fix it and I'll approve.
providers/google/src/airflow/providers/google/cloud/triggers/cloud_run.py
Outdated
Show resolved
Hide resolved
…to 'grpc' when None is provided, ensuring backward compatibility. Updated related logic for consistency
shahar1
approved these changes
Jan 24, 2026
olegkachur-e
approved these changes
Jan 26, 2026
Contributor
Author
|
@uranusjr could you please approve the changes and merge the PR |
85 tasks
shreyas-dev
pushed a commit
to shreyas-dev/airflow
that referenced
this pull request
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #60389
Summary
Adds support for specifying the transport protocol (REST or gRPC) in
CloudRunHook,CloudRunAsyncHook,CloudRunExecuteJobOperator, andCloudRunJobFinishedTriggerto resolve 404 errors in Docker environments where gRPC transport fails.Problem
CloudRunExecuteJobOperatorfails with 404 errors (NotFound: 404 Requested entity was not found) when running in Docker containers, even though the same Cloud Run jobs work correctly withgcloudCLI. This occurs because the Google Cloud Python client defaults to gRPC transport, which can fail in Docker environments due to network configurations, proxy settings, or firewall restrictions.Solution
Added an optional
transportparameter to:CloudRunHook- allows specifying 'rest' or 'grpc' transport forJobsClientCloudRunAsyncHook- allows specifying transport forJobsAsyncClientCloudRunExecuteJobOperator- passes transport parameter to the hookCloudRunJobFinishedTrigger- passes transport parameter to async hook for deferrable operations