-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Providers: JDBC provider updated for conf import migration #60050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Providers: JDBC provider updated for conf import migration #60050
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
|
Thanks @Aditi102005 !! The import statement If possible we can update these statements |
|
Static checks are failing !! Could you please fix them ? |
2a67560 to
07ca8aa
Compare
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
|
You have issues to fix - > both MyPy and regular static checks (which can be fixed with |
|
I’m working on Windows where some prek hooks (including mypy-providers and UI-related hooks) fail locally due to path/node limitations. |
|
Need to fix static checks. (You can also check locally with |
|
@Aditi102005, this PR needs a fix for static checks. |
|
Hello @Aditi102005 - The same static errors persist, unfortunately. It will be great to follow steps as per the documentation link mentioned below, to use WSL/Linux on your Windows machine, so no one has to suggest changes to you. I was in same boat as you and after implementing as per steps in below link, have set up to be able run static checks from my end, before any PR commits. Please feel free to post any blockers in Slack channel #new-contributors, so the community can help out. https://github.com/apache/airflow/blob/main/contributing-docs/03_contributors_quick_start.rst For the static error, if you observe closely, there is a line between the lines "requires-python = ">=3.10"" and "# The dependencies should be modified in place in the generated file." that got introduced as a typo when you were making changes, causing the static checks to fail. As mentioned above by everyone, using "prek" fixes any static checks automatically. Good luck! |
Updates the JDBC provider to stop importing
conffromairflow.configurationand instead use the shared compat SDK import:
from airflow.providers.common.compat.sdk import confThis aligns the JDBC provider with the recommended approach for
Airflow 2.11+ and Airflow 3.x compatibility.
Fixes #60000