add redis statefulset persistentVolumeClaimRetentionPolicy support #59955
+14
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgvishnuram
requested review from
hussein-awala,
jedcunningham and
jscheffl
as code owners
jscheffl
approved these changes
Dec 31, 2025
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Looks good to me and makes sense to define this attribute!
stegololz
pushed a commit
to stegololz/airflow
that referenced
this pull request
Jan 9, 2026
danielhoherd
pushed a commit
to astronomer/airflow
that referenced
this pull request
Jan 12, 2026
96 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Description
Currently when a user provisions an airflow deployment using helm with celery executor on kubernetes, redis statefulset is spinned up provisioned with a storage sized to 1gb by default. when a user tries to switch the executor type to kubernetes and triggers a upgrade through helm components matching the executor type will either gets removed or updated.
The core problem here redis pvc is still present in the same namespace due to the default behaviour of how the persistentVolumeClaimRetentionPolicy is set to retain by default.
What this PR does
This PR adds configurable persistentVolumeClaimRetentionPolicy into redis statefulset allows the user to decide either to delete the pvc provisioned by the redis statefulset or to retain them upon deletion