Skip to content

Conversation

@zezaeoh
Copy link
Contributor

@zezaeoh zezaeoh commented Dec 15, 2025

Issue

The pod-template-file.kubernetes-helm-yaml file provided as the default pod-template is missing a rendering condition for git_sync_ssh_key_volume when the SSH key is directly specified in the values (as opposed to using a secret reference).

Changes

This PR adds the missing condition to properly render the git sync SSH key volume in this use case.

@boring-cyborg
Copy link

boring-cyborg bot commented Dec 15, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Dec 15, 2025
@zezaeoh zezaeoh requested a review from dstandish as a code owner December 16, 2025 09:16
@zezaeoh zezaeoh requested a review from Miretpl December 16, 2025 09:29
@zezaeoh zezaeoh requested a review from Miretpl December 16, 2025 22:39
@potiuk
Copy link
Member

potiuk commented Dec 17, 2025

@Miretpl -> WDYT ?

Copy link
Contributor

@Miretpl Miretpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@potiuk approved

@potiuk potiuk merged commit 1c70306 into apache:main Dec 17, 2025
92 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 17, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Lohith625 pushed a commit to Lohith625/airflow that referenced this pull request Dec 19, 2025
…59418)

* fix: fix rendering condition of "git_sync_ssh_key_volume"

* test: add test case

* test: split the case
@jscheffl jscheffl added this to the Airflow Helm Chart 1.19.0 milestone Jan 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants