-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Bump prek lower bound to 0.2.0 #58952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
When the prek version is lower than required, the error message from (previously it was just Maybe in a followup PR we could make In both scenarios the script assumes it's waiting for a prek job that started successfully and could fail, not for a job that didn't start (and I think we can dry-run / check that before launching everything else, since if prek fails then the entire machinery is destined to fail at some point -- otherwise we'd get a warning, not an error). Not sure if it's worth it to fix that though -- maybe it's too much of an edge case? |
Otherwise hooks aren't discovered recursively via workspaces feature
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
Backport failed to create: v3-1-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker b95fca4 v3-1-testThis should apply the commit to the v3-1-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
Yes - we could. We already do that for other things so checking for prek (but specifically when prek should be used) is a good idea. This is actually a very important point to fix those things and give as good of a message for all those edge cases as it makes it easier for new contributos. We usually discover always something when new person starts using things and we usually relentlessly fix it :) |
|
Actually - we even have the right method - we just do not call it in |
Otherwise hooks aren't discovered recursively via workspaces feature (cherry picked from commit b95fca4) Co-authored-by: Bartosz Sławecki <bartosz@slawecki.dev>
|
Backport in #58977 |
Otherwise hooks aren't discovered recursively via workspaces feature
Otherwise hooks aren't discovered recursively via workspaces feature

Otherwise (i.e., if we use prek < 0.2.0)
breeze start-airflowcan't start Airflow from top-level as it relies on nested.pre-commit-config.ymldiscovery that's been introduced in prek 0.2.0 ("Workspace Mode").I'll mark as ready after confirming the minimum version works like a breeze.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.