Add EdgeExecutor to KEDA query #55560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfdn
requested review from
dstandish,
hussein-awala and
jedcunningham
as code owners
jscheffl
approved these changes
Sep 12, 2025
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
(Also here) tests need to be adjusted. Otherwise looks good for me! Thanks for the extension!
Would it be also possible to reverse the match and filter only by any executor which is like "Celery" in the name and "null" is Celery is in the name of the default executor (==first)?
Contributor
|
Conflicts need resolution |
…utor-to-keda-query
Contributor
Author
I guess it should be possible to come up with a more generic query where do not need to list all executors != Celery. Maybe we can do this in a follow up PR - probably such a change requires some more testing. |
jscheffl
approved these changes
Sep 15, 2025
yash1thsa
pushed a commit
to yash1thsa/airflow
that referenced
this pull request
Sep 16, 2025
* Add EdgeExecutor to KEDA query * Adapt unit tests
suman-himanshu
pushed a commit
to suman-himanshu/airflow
that referenced
this pull request
Sep 17, 2025
* Add EdgeExecutor to KEDA query * Adapt unit tests
ArthurKretzer
pushed a commit
to ArthurKretzer/airflow
that referenced
this pull request
Sep 17, 2025
* Add EdgeExecutor to KEDA query * Adapt unit tests
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Sep 30, 2025
* Add EdgeExecutor to KEDA query * Adapt unit tests
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 1, 2025
* Add EdgeExecutor to KEDA query * Adapt unit tests
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 2, 2025
* Add EdgeExecutor to KEDA query * Adapt unit tests
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 3, 2025
* Add EdgeExecutor to KEDA query * Adapt unit tests
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 4, 2025
* Add EdgeExecutor to KEDA query * Adapt unit tests
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
* Add EdgeExecutor to KEDA query * Adapt unit tests
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
* Add EdgeExecutor to KEDA query * Adapt unit tests
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 7, 2025
* Add EdgeExecutor to KEDA query * Adapt unit tests
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 8, 2025
* Add EdgeExecutor to KEDA query * Adapt unit tests
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 9, 2025
* Add EdgeExecutor to KEDA query * Adapt unit tests
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 10, 2025
* Add EdgeExecutor to KEDA query * Adapt unit tests
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 11, 2025
* Add EdgeExecutor to KEDA query * Adapt unit tests
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 12, 2025
* Add EdgeExecutor to KEDA query * Adapt unit tests
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 14, 2025
* Add EdgeExecutor to KEDA query * Adapt unit tests
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 15, 2025
* Add EdgeExecutor to KEDA query * Adapt unit tests
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 17, 2025
* Add EdgeExecutor to KEDA query * Adapt unit tests
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 19, 2025
* Add EdgeExecutor to KEDA query * Adapt unit tests
96 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the EdgeExecutor to the default KEDA query in the Helm chart.
Why do we use "IS DISTINCT FROM" here for the comparison of the executor field? See: #55559
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.