Ensure that both public and ui dags endpoints map to DagService #51226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the dags router in ui endpoint was `Dags` while public was `DAG`. This resulted in the service being generated as DagsService for UI and DagService for public. But, probably better to have them generated under same service, and not just differ by the one letter.
dstandish
requested review from
bbovenzi,
pierrejeambrun,
ryanahamilton,
jscheffl,
shubhamraj-git,
ephraimbuddy,
rawwar,
jason810496 and
bugraoz93
as code owners
boring-cyborg
bot
added
area:API
jason810496
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the dags router in ui endpoint was
Dagswhile public wasDAG. This resulted in the service being generated as DagsService for UI and DagService for public. But, probably better to have them generated under same service, and not just differ by the one letter.