Rds Operator pass custom conn_id to superclass

[dominikhei]

---

Fixes #50766

I have adjusted the RdsBaseOperator class to explicitly pass the aws_conn_id to its superclass, such that if a custom conn_id is provided the super class does not fall back to the default and the base classes receive the correct conn_id.

Moreover I have adjusted the name of the default value of the aws_conn_id in RdsBaseOperator from aws_conn_id to aws_default , to be consistent with the RdsBaseOperator and all other operators.

[dominikhei]

@o-nikolas I was just skimming through the other AWS operators to look for similar bugs and found that the operators for cloud formation, comprehend and glue still set the aws_conn_id in their own constructors (all have the AWSBaseOperator as their superclass). This does obv. not change any functionality but shall I remove the aws_conn_id from them as well, for better consistency?

[o-nikolas]

@o-nikolas I was just skimming through the other AWS operators to look for similar bugs and found that the operators for cloud formation, comprehend and glue still set the aws_conn_id in their own constructors (all have the AWSBaseOperator as their superclass). This does obv. not change any functionality but shall I remove the aws_conn_id from them as well, for better consistency?

Yupp, that's a reasonable plan, would you like to put up a separate PR for that?

[dominikhei]

@o-nikolas I was just skimming through the other AWS operators to look for similar bugs and found that the operators for cloud formation, comprehend and glue still set the aws_conn_id in their own constructors (all have the AWSBaseOperator as their superclass). This does obv. not change any functionality but shall I remove the aws_conn_id from them as well, for better consistency?

Yupp, that's a reasonable plan, would you like to put up a separate PR for that?

Already opened it #51236 :)