AIP-72: Improve Supervisor and Task Instance State Validation #44405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds test that Supervisor prevents starting a Task Instance that is already running. Also updated `test_ti_update_state_conflict_if_not_queued` to use parameterized states, covering all non-queued Task Instance states. This is part of my efforts to port LocalTaskJob tests to Supervisor: apache#44356. This ports over `TestLocalTaskJob.test_localtaskjob_double_trigger`
kaxil
added
the
area:task-execution-interface-aip72
phanikumv
approved these changes
Nov 27, 2024
ashb
approved these changes
Nov 27, 2024
|
Oh, it might be worth extending this to check that the task code itself is never actually invoked? I'm not quite sure how we might do that across the subprocess though |
ArshiaZr
pushed a commit
to ArshiaZr/airflow
that referenced
this pull request
Nov 27, 2024
LefterisXefteris
pushed a commit
to LefterisXefteris/airflow
that referenced
this pull request
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds test that Supervisor prevents starting a Task Instance that is already running. Also updated
test_ti_update_state_conflict_if_not_queuedto use parameterized states, covering all non-queued Task Instance states.This is part of my efforts to port LocalTaskJob tests to Supervisor: #44356.
This ports over
TestLocalTaskJob.test_localtaskjob_double_trigger^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.