Fix: Only quote the keys of the query_parameters in MSGraphOperator #39207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igger only encodes the keys and not the values otherwise those will be encoded twice
boring-cyborg
bot
added
area:providers
provider:microsoft-azure
dabla
changed the title
eladkal
approved these changes
Apr 24, 2024
RodrigoGanancia
pushed a commit
to RodrigoGanancia/airflow
that referenced
this pull request
May 10, 2024
…pache#39207) * fix: Make sure the encoded_query_parameters function of the MSGraphTrigger only encodes the keys and not the values otherwise those will be encoded twice * refactor: Added missing coma --------- Co-authored-by: David Blain <david.blain@infrabel.be>
66 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the keys and values of the passed query_parameters where encoded by the MSGraphOperator. The issue with this is that the underlying kiota library (RequestInformation class) used by the msgraph-core library also encodes the values, which leads to double URL encoded values and thus giving issues, which I wasn't aware of until now when we had values with special characters in it. So now only the keys of the query_parameters are URL encoded, I've added a unit test which verifies this.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.