openlineage, snowflake: do not run external queries for Snowflake when #39113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:common-sql
provider:openlineage
kacpermuda
reviewed
Apr 18, 2024
kacpermuda
approved these changes
Apr 18, 2024
|
tests are failing |
Signed-off-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
mobuchowski
force-pushed
the
snowflake-openlineage-dontuseexternalconnection
branch
from
e94fb08
to
3b26f58
Compare
|
@RNHTTR not anymore :) |
potiuk
approved these changes
Apr 20, 2024
This was referenced May 3, 2024
Closed
RodrigoGanancia
pushed a commit
to RodrigoGanancia/airflow
that referenced
this pull request
May 10, 2024
…ache#39113) Signed-off-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we call Snowflake (and other DBs) to get schemas of tables used in particular queries.
However, Snowflake connector management is buggy and leaves us in a hanging, deadlocked state sometimes, which causes OpenLineage collection to fail and .
This PR prevents that by never calling Snowflake during OpenLineage method execution, and relying purely on information received from SQL parsing and Airflow Connection.
The negative consequence of that PR is lack of schema information in OpenLineage events, but this is a good tradeoff - most important feature of OpenLineage should be not affecting running tasks.