Fix few small release issues found during 2.8.2 preparation #37633
+45
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
Taragolis,
amoghrajesh,
ephraimbuddy and
hussein-awala
and removed request for
jedcunningham
potiuk
force-pushed
the
fix-small-issues-with-release-packages
branch
from
5c07097 to
7666314
Compare
* when deleting the whole .build folder, the www folder could not be created during asset compilation * -source packages were treated as sdist and we attempted to build wheel files with them * when building airflow packages, default settting (for security reasons) is to build everything in docker container, but building wheel for sdist was done outside. With this PR we only use sdist check when we use local hatch build - and sdist wheel check happens in docker container when sdists are built. * tarball was prepared before the pypi packages and it has been deleted by local hatch build
potiuk
force-pushed
the
fix-small-issues-with-release-packages
branch
from
7666314 to
56844ad
Compare
jedcunningham
approved these changes
Feb 22, 2024
ephraimbuddy
approved these changes
Feb 22, 2024
sudiptob2
pushed a commit
to Satoshi-Sh/airflow
that referenced
this pull request
Feb 22, 2024
…7633) * when deleting the whole .build folder, the www folder could not be created during asset compilation * -source packages were treated as sdist and we attempted to build wheel files with them * when building airflow packages, default settting (for security reasons) is to build everything in docker container, but building wheel for sdist was done outside. With this PR we only use sdist check when we use local hatch build - and sdist wheel check happens in docker container when sdists are built. * tarball was prepared before the pypi packages and it has been deleted by local hatch build
ephraimbuddy
pushed a commit
that referenced
this pull request
Feb 22, 2024
* when deleting the whole .build folder, the www folder could not be created during asset compilation * -source packages were treated as sdist and we attempted to build wheel files with them * when building airflow packages, default settting (for security reasons) is to build everything in docker container, but building wheel for sdist was done outside. With this PR we only use sdist check when we use local hatch build - and sdist wheel check happens in docker container when sdists are built. * tarball was prepared before the pypi packages and it has been deleted by local hatch build (cherry picked from commit 254d7eb)
68 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deleted by local hatch build
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.