Skip to content

Update operator_extra_links property #34506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Taragolis merged 2 commits into from
Sep 21, 2023
Merged

Update operator_extra_links property #34506

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
922f41f
Update operator_extra_links property
asherkhb Sep 20, 2023
8d87684
Merge branch 'main' into fix_mapped_batch_operator
asherkhb Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions airflow/providers/amazon/aws/operators/batch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
from airflow.configuration import conf
from airflow.exceptions import AirflowException, AirflowProviderDeprecationWarning
from airflow.models import BaseOperator
from airflow.models.mappedoperator import MappedOperator
from airflow.providers.amazon.aws.hooks.batch_client import BatchClientHook
from airflow.providers.amazon.aws.links.batch import (
BatchJobDefinitionLink,
Expand Down Expand Up @@ -126,9 +127,21 @@ class BatchOperator(BaseOperator):
@property
def operator_extra_links(self):
op_extra_links = [BatchJobDetailsLink()]
if self.wait_for_completion:

if isinstance(self, MappedOperator):
wait_for_completion = self.partial_kwargs.get(
"wait_for_completion"
) or self.expand_input.value.get("wait_for_completion")
array_properties = self.partial_kwargs.get("array_properties") or self.expand_input.value.get(
"array_properties"
)
else:
wait_for_completion = self.wait_for_completion
array_properties = self.array_properties

if wait_for_completion:
op_extra_links.extend([BatchJobDefinitionLink(), BatchJobQueueLink()])
if not self.array_properties:
if not array_properties:
# There is no CloudWatch Link to the parent Batch Job available.
op_extra_links.append(CloudWatchEventsLink())

Expand Down