-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor operator links to not create ad hoc TaskInstances #21285
Conversation
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ it
Merging. The only failure is the MsSQL that I work on in #21272 |
This operator link creates an ad hoc TaskInstance to build its output URL. Generally we moved away from this approach starting with apache#21285. This PR updates the operator link to use `TaskInstance.get_task_instance()` instead.
This operator link creates an ad hoc TaskInstance to build its output URL. Generally we moved away from this approach starting with apache#21285. This PR updates the operator link to use `TaskInstance.get_task_instance()` instead.
This operator link creates an ad hoc TaskInstance to build its output URL. Generally we moved away from this approach starting with apache#21285. This PR updates the operator link to use `TaskInstance.get_task_instance()` instead.
This operator link creates an ad hoc TaskInstance to build its output URL. Generally we moved away from this approach starting with apache#21285. This PR updates the operator link to use `TaskInstance.get_task_instance()` instead.
This operator link creates an ad hoc TaskInstance to build its output URL. Generally we moved away from this approach starting with #21285. This PR updates the operator link to use `TaskInstance.get_task_instance()` instead.
Given that there is now a foreign key constraint between
TaskInstance
andDagRun
, ideally ad hocTaskInstance
objects shouldn't be created within operator links. See this comment.Almost all of the existing operator links can be refactored to using
XCom.get_one()
to pull the necessaryXCom
to generate the URL needed.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.