Refactor vertica_to_mysql to make it more 'mypy' friendly #20618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @subkanthi |
|
Anyone :) ? |
subkanthi
reviewed
Jan 4, 2022
Part of apache#19891 MyPy was confused by the logic in this method (and so humans could be) because there were some implicit relations between bulk_load and tmpfle. This refector makes the bulk_load and non-bulk load separate (extracting common parts) and more obvious. Thanks MyPy for flagging this one.
potiuk
force-pushed
the
refactor_vertica_to_mysql
branch
from
3c8e20b
to
9020f23
Compare
eladkal
approved these changes
Jan 5, 2022
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
This was referenced Feb 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #19891
MyPy was confused by the logic in this method (and so humans could
be) because there were some implicit relations between bulk_load
and tmpfle. This refector makes the bulk_load and non-bulk load
separate (extracting common parts) and more obvious.
Thanks MyPy for flagging this one.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.