Fix template_fields type to have MyPy friendly Sequence type #20571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
provider:cncf-kubernetes
potiuk
force-pushed
the
fix-template-fields-mypy-sequence
branch
from
28a922a
to
51ba7a6
Compare
|
Another "global" mypy fix - constistently set type of "template_fiellds" (fixes quite a number of mypy bugs across many packages). |
josh-fell
reviewed
Dec 30, 2021
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
potiuk
force-pushed
the
fix-template-fields-mypy-sequence
branch
from
51ba7a6
to
8e6bd39
Compare
|
I replaced all the arrays and set with tuples too. |
mik-laj
approved these changes
Dec 30, 2021
potiuk
force-pushed
the
fix-template-fields-mypy-sequence
branch
from
8e6bd39
to
2df1da9
Compare
This was referenced Feb 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #19891
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.