Standardize AWS Redshift naming #20374
Conversation
boring-cyborg
bot
added
area:providers
provider:amazon-aws
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
| @@ -58,3 +58,19 @@ def get_hook(self) -> RedshiftHook: | |||
|
|
|||
| self.hook = RedshiftHook(aws_conn_id=self.aws_conn_id) | |||
| return self.hook | |||
|
|
|||
|
|
|||
| class AwsRedshiftClusterSensor(RedshiftClusterSensor): | |||
There was a problem hiding this comment.
We dont need deprecation here.
This is a new class added recently in https://github.com/apache/airflow/pull/20276/files
This was never released to users so we can avoid this deprecation.
There is no point in releasing a class which is already deprecated :)
We should redirect from
https://github.com/apache/airflow/blob/main/airflow/providers/amazon/aws/sensors/redshift.py
directly to the RedshiftClusterSensor
ferruzzi
requested review from
ashb,
jedcunningham,
kaxil and
potiuk
as code owners
ferruzzi
force-pushed
the
rename-redshift
branch
from
3030c11
to
8e2d48a
Compare
|
rebased and I think I covered #20374 (comment) |
|
This one is throwing the Protocol inheritance error that I mentioned in the other PR: https://github.com/apache/airflow/runs/4708697673?check_suite_focus=true#step:8:8489 |
ferruzzi
force-pushed
the
rename-redshift
branch
from
8e2d48a
to
7999566
Compare
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
eladkal
removed
the
full tests needed
|
Merging for now as it's pretty much the same to all other strandrization PRs |
Part of #20296
Also changed
poke(None)topoke({})because IDE type hinting warnings (expected dict, received NoneType)^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.