Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize AWS ECS naming #20332

Merged
merged 2 commits into from
Jan 4, 2022
Merged

Standardize AWS ECS naming #20332

merged 2 commits into from
Jan 4, 2022

Conversation

ferruzzi
Copy link
Contributor

Part of #20296


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@ferruzzi
Copy link
Contributor Author

Rebased to resolve merge conflicts.

@eladkal
Copy link
Contributor

eladkal commented Dec 19, 2021

We also have

class ECSOperatorError(Exception):
"""Raise when ECS cannot handle the request."""
def __init__(self, failures: list, message: str):
self.failures = failures
self.message = message
super().__init__(message)

@ferruzzi
Copy link
Contributor Author

ferruzzi commented Jan 3, 2022

I was away for the holidays, but I think this one is ready to go?

@eladkal
Copy link
Contributor

eladkal commented Jan 4, 2022

I was away for the holidays, but I think this one is ready to go?

see #20332 (comment)
I wasn't able to reproduce what you described

@ferruzzi
Copy link
Contributor Author

ferruzzi commented Jan 4, 2022

Huh. Neither can I now. I've rebased and removed the Protocol inheritance on L546.

Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
will merge when CI is green

@github-actions
Copy link

github-actions bot commented Jan 4, 2022

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers kind:documentation okay to merge It's ok to merge this PR as it does not require more tests provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants