Replace requests with httpx #15846
Closed
Replace requests with httpx #15846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
force-pushed
the
replace-requests-with-httpx
branch
from
d81baf1
to
4a8ef86
Compare
potiuk
force-pushed
the
replace-requests-with-httpx
branch
from
4a8ef86
to
5ed42b2
Compare
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
potiuk
force-pushed
the
replace-requests-with-httpx
branch
from
5ed42b2
to
79505d7
Compare
This change replaces `requests` with httpx in the providers that are derived from http provider. This change is related to apache#15781 and was introduced initially to handle problem described in: https://issues.apache.org/jira/browse/LEGAL-572 However since we have a PR in progress to make chardet an optional dependency in `requests` library psf/requests#5797 and changing `requests` to `http` introduced backwards-incompatibility, we might decide not to merge this PR - depending on how quickly (if) `requests` library adopts the change. Providers affected: * http * airbyte * apache.livy * opsgenie * slack Depends on apache#15781
potiuk
force-pushed
the
replace-requests-with-httpx
branch
from
79505d7
to
4ba6f91
Compare
|
The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the workflow link to check the reason. |
|
Not needed after upcoming removal of chardet as mandatory dependency for requests: psf/requests#5797 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces
requestswith httpx in the providersthat are derived from http provider. This change is related
to #15781 and was introduced initially to handle problem
described in:
https://issues.apache.org/jira/browse/LEGAL-572
However since we have a PR in progress to make chardet
an optional dependency in
requestslibrarypsf/requests#5797
and changing
requeststohttpintroduced backwards-incompatibility,we might decide not to merge this PR - depending on how
quickly (if)
requestslibrary adopts the change.Providers affected:
Depends on #15781
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.