Allow PID file path to be relative when daemonize a process (scheduler, kerberos, etc) #13232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XD-DENG
changed the title
turbaszek
approved these changes
Dec 21, 2020
ashb
requested changes
Dec 21, 2020
potiuk
approved these changes
Dec 22, 2020
XD-DENG
changed the title
|
This PR is updated to adopt different solution, based on the latest discussion in #13200 . |
XD-DENG
changed the title
…r, kerberos, etc) Closes apache#13200. Currently, if the PID file path provided is relative, the process silently fails to launch. This fix ensures the PID path specified to be a normalized absolutized path eventually (expand with cwd), no matter the given value is relative or absolute.
potiuk
approved these changes
Dec 22, 2020
|
@ashb any further inputs before we merge this? |
ashb
approved these changes
Dec 22, 2020
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Dec 23, 2020
…r, kerberos, etc) (apache#13232) Closes apache#13200. Currently, if the PID file path provided is relative, the process silently fails to launch. This fix ensures the PID path specified to be a normalized absolutized path eventually (expand with cwd), no matter the given value is relative or absolute. (cherry picked from commit 93e4787)
kaxil
pushed a commit
that referenced
this pull request
Jan 21, 2021
…r, kerberos, etc) (#13232) Closes #13200. Currently, if the PID file path provided is relative, the process silently fails to launch. This fix ensures the PID path specified to be a normalized absolutized path eventually (expand with cwd), no matter the given value is relative or absolute. (cherry picked from commit 93e4787)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13200 (please refer to #13200 for detailed background and discussion.)
Currently, if the PID file path provided is relative, the process silently fails to launch.
This fix ensures the path specified to be a normalized absolutized path eventually (expand with cwd), no matter the given value is relative or absolute.
This PR also tries to increase coverage a little bit.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.