Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FABAuthManager migrate endpoints to FastAPI #44881

Open
pierrejeambrun opened this issue Dec 12, 2024 · 4 comments
Open

FABAuthManager migrate endpoints to FastAPI #44881

pierrejeambrun opened this issue Dec 12, 2024 · 4 comments
Assignees

Comments

@pierrejeambrun
Copy link
Member

pierrejeambrun commented Dec 12, 2024

Description

Depends on: #44847

FABAuthManager defines extra flask endpoints.

As part of the migration to FastAPI these endpoints need to be converted to FastAPI.

Endpoints located in airflow/providers/fab/auth_manager/api_endpoints needs to be converted to FastAPI. (Duplicated for now, legacy flask endpoint will be removed later)

@pierrejeambrun pierrejeambrun added kind:feature Feature Requests kind:meta High-level information important to the community area:auth and removed kind:meta High-level information important to the community labels Dec 12, 2024
@pierrejeambrun
Copy link
Member Author

cc: @vincbeck

@andreimek
Copy link

Hi @pierrejeambrun,
I would like to work on this issue.

@phanikumv
Copy link
Contributor

Assigned to you @andreimek , thanks

@jedcunningham
Copy link
Member

Related to the discussion in #44883, we likely don't need to actually rewrite or convert these, just wrap them with WSGIMiddleware when auth managers start exposing fastapi subapps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants