-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update taskinstance clear endpoint to support mapped tasks #44867
Comments
I can work on this. Assigning it to myself. |
@eladkal Should I also create an Issue to migrate this to FastAPI as well? |
No need for another issue. You can simply start another PR directly |
@eladkal We do have taskinstance clear endpoint implementation already here. As per openapi spec its under DAG endpoint here. In FastAPI we have correctly added this under taskinstances. Do let me know if this is what you wanted in implementation, if yes should I move this endpoint from DAG to TaskInstance in legacy API? |
In my perspective yes. I expect to find clear action on task instance endpoints but I think it's a good idea to track the PR added it and see if there was discussion around why it's placed there. We may be missing something. By the way, it seems like with current endpoint you are not able to clear a specific map index in a specific task instance so I think we need to add support for this. |
Maybe we should close this one, or update it in favor of a feature request for a more fined grained clearing capabilities on 'mapped task instances' ? As I understand the endpoint exists, it just needs improvement ? |
Updated title and description |
Body
We are missing clear endpoint in the taskinstance apiWe need the endpoint to have same functionality as clear button in the UI.Note: The task needs to accommodate both clearing a task and clearing a map index (when using dynamic task mapping)
for reference you can see previous PRs that added functionality to the Rest API: #41017, #39138Update (after discussing in comments)
Committer
The text was updated successfully, but these errors were encountered: