Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP-38 | Show historic metrics in Dashboard #42700

Open
bbovenzi opened this issue Oct 3, 2024 · 4 comments
Open

AIP-38 | Show historic metrics in Dashboard #42700

bbovenzi opened this issue Oct 3, 2024 · 4 comments
Assignees
Labels
area:UI Related to UI/UX. For Frontend Developers. kind:feature Feature Requests

Comments

@bbovenzi
Copy link
Contributor

bbovenzi commented Oct 3, 2024

Once #42629 is merged, we can initialize our new homepage dashboard.

Right now historical_metrics only includes total counts. So we can build this part of the Dashboard mockups except for the bar graphs:

Image

That includes:

  • a date range selector
  • horizontal bar graphs showing the total count of dag run and task instance states and their overall percentage

We'll ignore dag run type for now.

@bbovenzi bbovenzi converted this from a draft issue Oct 3, 2024
@dosubot dosubot bot added the area:UI Related to UI/UX. For Frontend Developers. label Oct 3, 2024
@bbovenzi bbovenzi changed the title Initialize new Dashboard page AIP-38 | Initialize new Dashboard page Oct 3, 2024
@bbovenzi bbovenzi added kind:feature Feature Requests kind:meta High-level information important to the community and removed kind:feature Feature Requests kind:meta High-level information important to the community labels Oct 8, 2024
@bbovenzi bbovenzi changed the title AIP-38 | Initialize new Dashboard page AIP-38 | Show historic metrics in Dashboard Oct 8, 2024
@bbovenzi bbovenzi added the kind:feature Feature Requests label Oct 8, 2024
@tirkarthi
Copy link
Contributor

@bbovenzi I can take this up if you are okay. I have prototyped below versions as per design without the checkbox and the bar charts which don't have data from API. I can raise this as PR for the base part and fine tune the UI/UX during review or subsequent PRs.

image

image

@bbovenzi
Copy link
Contributor Author

Nice! One nit, let's keep the phrase "Task Instances".
We'll probably want to update the historical_metrics endpoint to better fit this view. But that's a separate issue

@tirkarthi
Copy link
Contributor

@bbovenzi I am building the asset events section in the dashboard. As part of the dashboard designs the asset events was also to the right of historical metrics so my question is do they belong to the same section and are affected by the time range filter selected? If I select last 1 hour does historical metrics along with the asset events display the last 1 hour metrics only?

#42371 (comment)

@bbovenzi
Copy link
Contributor Author

Yeah, I guess they would be. I'll be honest though, I think the dashboard view is subject to a lot of change from what the designs are now and what we will have when 3.0 comes out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. kind:feature Feature Requests
Projects
Development

No branches or pull requests

2 participants